From 8b27765d67604009e117476e66f6b9297e7c9e33 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Tue, 16 Dec 2014 16:30:24 +0000 Subject: [PATCH] eal: use safe snprintf to print version When printing the version string to a local variable, use snprintf for safety over sprintf. This is general good practice even if the values to print are all hard-coded. Signed-off-by: Bruce Richardson --- lib/librte_eal/common/include/rte_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_eal/common/include/rte_version.h b/lib/librte_eal/common/include/rte_version.h index 54cb9a6364..356207cc2f 100644 --- a/lib/librte_eal/common/include/rte_version.h +++ b/lib/librte_eal/common/include/rte_version.h @@ -104,13 +104,13 @@ rte_version(void) if (version[0] != 0) return version; if (strlen(RTE_VER_SUFFIX) == 0) - sprintf(version, "%s %d.%d.%d", + snprintf(version, sizeof(version), "%s %d.%d.%d", RTE_VER_PREFIX, RTE_VER_MAJOR, RTE_VER_MINOR, RTE_VER_PATCH_LEVEL); else - sprintf(version, "%s %d.%d.%d%s%d", + snprintf(version, sizeof(version), "%s %d.%d.%d%s%d", RTE_VER_PREFIX, RTE_VER_MAJOR, RTE_VER_MINOR, -- 2.20.1