From 8bac78f8262e2c4d8d72bf7e77c2d55b62b844f2 Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Thu, 7 Nov 2019 06:42:24 -0800 Subject: [PATCH] net/enic: re-enable link status change interrupt When INTx is used, the interrupt handler needs to explicitly re-enable interrupt in order to receive another one in future. The LSC interrupt handler currently does not, and the link state never gets updated when INTx is used (e.g. uio_pci_generic). Call rte_intr_ack() at the end of the handler, to re-enable INTx. Fixes: fefed3d1e62c ("enic: new driver") Cc: stable@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/Makefile | 2 ++ drivers/net/enic/enic_main.c | 2 ++ drivers/net/enic/meson.build | 2 ++ 3 files changed, 6 insertions(+) diff --git a/drivers/net/enic/Makefile b/drivers/net/enic/Makefile index 10736a567b..4e0c83da56 100644 --- a/drivers/net/enic/Makefile +++ b/drivers/net/enic/Makefile @@ -13,6 +13,8 @@ EXPORT_MAP := rte_pmd_enic_version.map LIBABIVER := 1 +# Experimental APIs used: rte_intr_ack +CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -I$(SRCDIR)/base/ CFLAGS += -I$(SRCDIR) CFLAGS += -O3 diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index f5b9b0dcbe..57574a5f7e 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -448,6 +448,8 @@ enic_intr_handler(void *arg) enic_link_update(dev); _rte_eth_dev_callback_process(dev, RTE_ETH_EVENT_INTR_LSC, NULL); enic_log_q_error(enic); + /* Re-enable irq in case of INTx */ + rte_intr_ack(&enic->pdev->intr_handle); } static int enic_rxq_intr_init(struct enic *enic) diff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build index 1bd7cc7e1b..e5eeb56675 100644 --- a/drivers/net/enic/meson.build +++ b/drivers/net/enic/meson.build @@ -1,6 +1,8 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Cisco Systems, Inc. +# Experimental APIs used: rte_intr_ack +cflags += ['-DALLOW_EXPERIMENTAL_API'] sources = files( 'base/vnic_cq.c', 'base/vnic_dev.c', -- 2.20.1