From 8ec36fb17b0139b02f559eb222b3ba8ff1abb997 Mon Sep 17 00:00:00 2001 From: Tal Shnaiderman Date: Sun, 11 Apr 2021 15:21:36 +0300 Subject: [PATCH] common/mlx5: add missing internal tags Several functions introduced in the addition of the Windows support to mlx5 were missing the __rte_internal tag. This miss is better revealed when symbols became exported on Linux too, and it is caught by the symbol checker with --buildtype=debug. Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on Windows") Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") Fixes: 56ea803e878e ("build: remove Windows export symbol list") Cc: stable@dpdk.org Signed-off-by: Tal Shnaiderman --- drivers/common/mlx5/linux/mlx5_common_os.h | 4 ++++ drivers/common/mlx5/windows/mlx5_common_os.h | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/common/mlx5/linux/mlx5_common_os.h b/drivers/common/mlx5/linux/mlx5_common_os.h index 63f070d9c4..d1c7e3dce0 100644 --- a/drivers/common/mlx5/linux/mlx5_common_os.h +++ b/drivers/common/mlx5/linux/mlx5_common_os.h @@ -203,24 +203,28 @@ mlx5_os_get_devx_uar_page_id(void *uar) #endif } +__rte_internal static inline void * mlx5_os_alloc_pd(void *ctx) { return mlx5_glue->alloc_pd(ctx); } +__rte_internal static inline int mlx5_os_dealloc_pd(void *pd) { return mlx5_glue->dealloc_pd(pd); } +__rte_internal static inline void * mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access) { return mlx5_glue->devx_umem_reg(ctx, addr, size, access); } +__rte_internal static inline int mlx5_os_umem_dereg(void *pumem) { diff --git a/drivers/common/mlx5/windows/mlx5_common_os.h b/drivers/common/mlx5/windows/mlx5_common_os.h index e92533c4d3..3756e1959b 100644 --- a/drivers/common/mlx5/windows/mlx5_common_os.h +++ b/drivers/common/mlx5/windows/mlx5_common_os.h @@ -248,11 +248,17 @@ mlx5_os_devx_subscribe_devx_event(void *eventc, return -ENOTSUP; } +__rte_internal void *mlx5_os_alloc_pd(void *ctx); +__rte_internal int mlx5_os_dealloc_pd(void *pd); +__rte_internal void *mlx5_os_umem_reg(void *ctx, void *addr, size_t size, uint32_t access); +__rte_internal int mlx5_os_umem_dereg(void *pumem); +__rte_internal int mlx5_os_reg_mr(void *pd, void *addr, size_t length, struct mlx5_pmd_mr *pmd_mr); +__rte_internal void mlx5_os_dereg_mr(struct mlx5_pmd_mr *pmd_mr); #endif /* RTE_PMD_MLX5_COMMON_OS_H_ */ -- 2.20.1