From 8f91f368a1e3cf078cc702794c3669f18d27311c Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Tue, 17 Apr 2018 11:57:52 +0100 Subject: [PATCH] mem: log page address before unmapping If user has specified a flag to unmap the area right after mapping it, we were passing an already-unmapped pointer to RTE_LOG. This is not an issue since RTE_LOG doesn't actually dereference the pointer, but fix it anyway by moving call to RTE_LOG to before unmap. Coverity issue: 272584 Fixes: b7cc54187ea4 ("mem: move virtual area function in common directory") Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- lib/librte_eal/common/eal_common_memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c index 24a9ed5225..3e30c58445 100644 --- a/lib/librte_eal/common/eal_common_memory.c +++ b/lib/librte_eal/common/eal_common_memory.c @@ -113,12 +113,12 @@ eal_get_virtual_area(void *requested_addr, size_t *size, RTE_LOG(WARNING, EAL, " This may cause issues with mapping memory into secondary processes\n"); } - if (unmap) - munmap(mapped_addr, map_sz); - RTE_LOG(DEBUG, EAL, "Virtual area found at %p (size = 0x%zx)\n", aligned_addr, *size); + if (unmap) + munmap(mapped_addr, map_sz); + baseaddr_offset += *size; return aligned_addr; -- 2.20.1