From 982e43658ce1b430f0ae3e384c372294fb78e3e3 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Wed, 15 May 2019 12:38:47 +0100 Subject: [PATCH] build: warn on unused parameter To improve code quality we want to turn on as many warnings as we can in the DPDK code, so turn on the "unused-parameter" warning in meson builds to match that of the make builds. To ensure correct compilation, disable the warning selectively for driver base code that otherwise would have issues. Signed-off-by: Bruce Richardson Acked-by: Luca Boccassi --- config/meson.build | 1 + drivers/net/i40e/base/meson.build | 3 ++- drivers/net/ice/base/meson.build | 1 + drivers/net/ixgbe/base/meson.build | 4 +++- 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/config/meson.build b/config/meson.build index 0d25646f56..dbdfde6b8f 100644 --- a/config/meson.build +++ b/config/meson.build @@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c') # enable extra warnings and disable any unwanted warnings warning_flags = [ + '-Wunused-parameter', '-Wsign-compare', '-Wcast-qual', '-Wno-address-of-packed-member' diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build index d4c8f872d5..13d16b08d5 100644 --- a/drivers/net/i40e/base/meson.build +++ b/drivers/net/i40e/base/meson.build @@ -13,7 +13,8 @@ sources = [ error_cflags = ['-Wno-sign-compare', '-Wno-unused-value', '-Wno-format', '-Wno-error=format-security', - '-Wno-strict-aliasing', '-Wno-unused-but-set-variable' + '-Wno-strict-aliasing', '-Wno-unused-but-set-variable', + '-Wno-unused-parameter', ] c_args = cflags if allow_experimental_apis diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build index 624202567c..eff155574d 100644 --- a/drivers/net/ice/base/meson.build +++ b/drivers/net/ice/base/meson.build @@ -16,6 +16,7 @@ sources = [ error_cflags = ['-Wno-unused-value', '-Wno-unused-but-set-variable', '-Wno-unused-variable', + '-Wno-unused-parameter', ] c_args = cflags diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build index 21ac64bf5c..bbd0f51ea5 100644 --- a/drivers/net/ixgbe/base/meson.build +++ b/drivers/net/ixgbe/base/meson.build @@ -18,7 +18,9 @@ sources = [ ] error_cflags = ['-Wno-unused-value', - '-Wno-unused-but-set-variable'] + '-Wno-unused-but-set-variable', + '-Wno-unused-parameter', + ] c_args = cflags if allow_experimental_apis c_args += '-DALLOW_EXPERIMENTAL_API' -- 2.20.1