From 996096e629c3b6d08eab4acf51122ff783350b39 Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Fri, 27 Apr 2018 11:04:38 +0200 Subject: [PATCH] vhost/crypto: fix build with gcc 4.7.2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Build error has been reported by Intel build system: SUSE12SP3_64 / Linux 3.7.10-1 / GCC 4.7.2 lib/librte_vhost/vhost_crypto.c: In function ‘rte_vhost_crypto_set_zero_copy’: lib/librte_vhost/vhost_crypto.c:1192:2: error: comparison of unsigned expression < 0 is always false As enums can be either signed or unsigned, this patch removes the negative check and cast to unsigned the upper limit check. Fixes: 939066d96563 ("vhost/crypto: add public function implementation") Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vhost_crypto.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c index c38eb3bb5d..c6fb2fe5f1 100644 --- a/lib/librte_vhost/vhost_crypto.c +++ b/lib/librte_vhost/vhost_crypto.c @@ -1189,8 +1189,8 @@ rte_vhost_crypto_set_zero_copy(int vid, enum rte_vhost_crypto_zero_copy option) return -EINVAL; } - if (unlikely(option < 0 || option >= - RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS)) { + if (unlikely((uint32_t)option >= + RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS)) { VC_LOG_ERR("Invalid option %i", option); return -EINVAL; } -- 2.20.1