From 9ad53189a372a5179f2b50f7a9dee016e45ffc17 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Wed, 21 Jun 2017 07:28:20 +0100 Subject: [PATCH] cryptodev: rename device retrieval argument rte_cryptodev_devices_get() function was parsing a crypto device name as an argument, but the function actually returns device identifiers of devices that share the same crypto driver, so the argument should be driver name, instead. Fixes: 38227c0e3ad2 ("cryptodev: retrieve device info") Cc: stable@dpdk.org Signed-off-by: Pablo de Lara Acked-by: Declan Doherty --- lib/librte_cryptodev/rte_cryptodev.c | 6 +++--- lib/librte_cryptodev/rte_cryptodev.h | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rte_cryptodev.c index cb3e23609d..8875304f8c 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -501,7 +501,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type) } uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices) { uint8_t i, count = 0; @@ -516,10 +516,10 @@ rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, if (drv) cmp = strncmp(drv->pci_drv.driver.name, - dev_name, strlen(dev_name)); + driver_name, strlen(driver_name)); else cmp = strncmp(devs[i].data->name, - dev_name, strlen(dev_name)); + driver_name, strlen(driver_name)); if (cmp == 0) devices[count++] = devs[i].data->dev_id; diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h index f307b3ba7d..89093f6250 100644 --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -464,9 +464,10 @@ extern uint8_t rte_cryptodev_count_devtype(enum rte_cryptodev_type type); /** - * Get number and identifiers of attached crypto device. + * Get number and identifiers of attached crypto devices that + * use the same crypto driver. * - * @param dev_name device name. + * @param driver_name driver name. * @param devices output devices identifiers. * @param nb_devices maximal number of devices. * @@ -474,7 +475,7 @@ rte_cryptodev_count_devtype(enum rte_cryptodev_type type); * Returns number of attached crypto device. */ uint8_t -rte_cryptodev_devices_get(const char *dev_name, uint8_t *devices, +rte_cryptodev_devices_get(const char *driver_name, uint8_t *devices, uint8_t nb_devices); /* * Return the NUMA socket to which a device is connected -- 2.20.1