From 9c0e15a11742d12cc96487cd4e0bb6a6fd2d5768 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Wed, 2 Sep 2020 08:34:59 +0000 Subject: [PATCH] vdpa/mlx5: fix completion queue assertion The CQ configuration enables the collapse feature in HW what cause HW to write all the completions in the first CQE. When this feature is enabled the HW doesn't switch the owner bit when it starts a new cycle of the CQ, not like working without the collapse feature. The current SW CQ polling wrongly added an assertion to validate the owner bit switch what causes a panic in debug mode. Remove the aforementioned assertion. Fixes: c5f714e50b0e ("vdpa/mlx5: optimize completion queue poll") Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Xueming Li Reviewed-by: Maxime Coquelin --- drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c index bda547ffe0..d0307b321f 100644 --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c @@ -213,8 +213,6 @@ mlx5_vdpa_cq_poll(struct mlx5_vdpa_cq *cq) comp = (cur_wqe_counter + 1u - next_wqe_counter) & cq_mask; if (comp) { cq->cq_ci += comp; - MLX5_ASSERT(!!(cq->cq_ci & cq_size) == - MLX5_CQE_OWNER(last_word.op_own)); MLX5_ASSERT(MLX5_CQE_OPCODE(last_word.op_own) != MLX5_CQE_INVALID); if (unlikely(!(MLX5_CQE_OPCODE(last_word.op_own) == -- 2.20.1