From 9d4aabe66aee0fd2a63846f56df16e77bc5e91b1 Mon Sep 17 00:00:00 2001 From: Pascal Mazon Date: Wed, 15 Mar 2017 15:48:12 +0100 Subject: [PATCH] net/tap: remove NO-ARP setting There is no reason not to support ARP on a tap netdevice. Remove IFF_NOARP flags. Focus on IFF_UP when a link status change is required. Fixes: f457b472b1f2 ("net/tap: add link up and down operations") Signed-off-by: Pascal Mazon Reviewed-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index a5cbb23e4c..fcf4a1dc3d 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -375,7 +375,7 @@ tap_link_set_down(struct rte_eth_dev *dev) struct pmd_internals *pmd = dev->data->dev_private; dev->data->dev_link.link_status = ETH_LINK_DOWN; - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 0); + return tap_link_set_flags(pmd, IFF_UP, 0); } static int @@ -384,7 +384,7 @@ tap_link_set_up(struct rte_eth_dev *dev) struct pmd_internals *pmd = dev->data->dev_private; dev->data->dev_link.link_status = ETH_LINK_UP; - return tap_link_set_flags(pmd, IFF_UP | IFF_NOARP, 1); + return tap_link_set_flags(pmd, IFF_UP, 1); } static int -- 2.20.1