From 9f0d4c6ba8c3076ebe63bdaa2ba9ed68afdc17f2 Mon Sep 17 00:00:00 2001 From: David Marchand Date: Fri, 26 Jul 2019 12:21:25 +0200 Subject: [PATCH] net/kni: do not count unsent packets as errors err_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index 884280c220..515c0aa14d 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -35,7 +35,6 @@ struct eth_kni_args { struct pmd_queue_stats { uint64_t pkts; uint64_t bytes; - uint64_t err_pkts; }; struct pmd_queue { @@ -97,7 +96,6 @@ eth_kni_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs) nb_pkts = rte_kni_tx_burst(kni, bufs, nb_bufs); kni_q->tx.pkts += nb_pkts; - kni_q->tx.err_pkts += nb_bufs - nb_pkts; return nb_pkts; } @@ -269,7 +267,6 @@ eth_kni_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) unsigned long rx_packets_total = 0, rx_bytes_total = 0; unsigned long tx_packets_total = 0, tx_bytes_total = 0; struct rte_eth_dev_data *data = dev->data; - unsigned long tx_packets_err_total = 0; unsigned int i, num_stats; struct pmd_queue *q; @@ -291,14 +288,12 @@ eth_kni_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->q_obytes[i] = q->tx.bytes; tx_packets_total += stats->q_opackets[i]; tx_bytes_total += stats->q_obytes[i]; - tx_packets_err_total += q->tx.err_pkts; } stats->ipackets = rx_packets_total; stats->ibytes = rx_bytes_total; stats->opackets = tx_packets_total; stats->obytes = tx_bytes_total; - stats->oerrors = tx_packets_err_total; return 0; } @@ -319,7 +314,6 @@ eth_kni_stats_reset(struct rte_eth_dev *dev) q = data->tx_queues[i]; q->tx.pkts = 0; q->tx.bytes = 0; - q->tx.err_pkts = 0; } } -- 2.20.1