From a10d79a60be3177afb41fa9eb08dfb2400b9a03a Mon Sep 17 00:00:00 2001 From: Shijith Thotton Date: Wed, 17 Mar 2021 13:34:19 +0530 Subject: [PATCH] eventdev: introduce adapter flags for periodic mode A timer adapter in periodic mode can be used to arm periodic timers. This patch adds flags used to advertise capability and configure timer adapter in periodic mode. Capability flag should be set for adapters which support periodic mode. Below is a programming sequence on the usage: /* check for periodic mode support by reading capability. */ rte_event_timer_adapter_caps_get(...); /* create adapter in periodic mode by setting periodic flag (RTE_EVENT_TIMER_ADAPTER_F_PERIODIC) and resolution. */ rte_event_timer_adapter_create_ext(...); /* arm periodic timer of configured resolution */ rte_event_timer_arm_burst(...); /* timer event will be periodically generated at configured resolution till cancel is called. */ while (running) { rte_event_dequeue_burst(...); } /* cancel periodic timer which stops generating events */ rte_event_timer_cancel_burst(...); Signed-off-by: Shijith Thotton Acked-by: Erik Gabriel Carrillo Acked-by: Jerin Jacob --- doc/guides/prog_guide/event_timer_adapter.rst | 16 +++++++++++++++- doc/guides/rel_notes/release_21_05.rst | 4 ++++ lib/librte_eventdev/rte_event_timer_adapter.h | 13 +++++++++++++ lib/librte_eventdev/rte_eventdev.h | 3 +++ 4 files changed, 35 insertions(+), 1 deletion(-) diff --git a/doc/guides/prog_guide/event_timer_adapter.rst b/doc/guides/prog_guide/event_timer_adapter.rst index a95efbe0d8..8b18cd169d 100644 --- a/doc/guides/prog_guide/event_timer_adapter.rst +++ b/doc/guides/prog_guide/event_timer_adapter.rst @@ -138,6 +138,18 @@ This function is passed a callback function that will be invoked if the adapter needs to create an event port, giving the application the opportunity to control how it is done. +Adapter modes +^^^^^^^^^^^^^ +An event timer adapter can be configured in either periodic or non-periodic mode +to support timers of the respective type. A periodic timer expires at a fixed +time interval repeatedly till it is cancelled. A non-periodic timer expires only +once. The periodic capability flag, ``RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC``, +can be set for implementations that support periodic mode if desired. To +configure an adapter in periodic mode, ``timer_adapter_flags`` of +``rte_event_timer_adapter_conf`` is set to include the periodic flag +``RTE_EVENT_TIMER_ADAPTER_F_PERIODIC``. Maximum timeout (``max_tmo_nsec``) does +not apply to periodic mode. + Retrieve Event Timer Adapter Contextual Information ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The event timer adapter implementation may have constraints on tick resolution @@ -229,7 +241,9 @@ Now we can arm the event timer with ``rte_event_timer_arm_burst()``: Once an event timer expires, the application may free it or rearm it as necessary. If the application will rearm the timer, the state should be reset -to RTE_EVENT_TIMER_NOT_ARMED by the application before rearming it. +to RTE_EVENT_TIMER_NOT_ARMED by the application before rearming it. Timer expiry +events will be generated once or periodically until the timer is cancelled based +on adapter mode. Multiple Event Timers with Same Expiry Value ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 38d580b825..cbe0ab1217 100644 --- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst @@ -149,6 +149,10 @@ New Features * Added support for multi-segments mbuf. +* **Introduced period timer mode in eventdev timer adapter.** + + * Added support for periodic timer mode in eventdev timer adapter. + * **Updated testpmd.** * Added a command line option to configure forced speed for Ethernet port. diff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h index d2ebcb0909..4e0d2a819b 100644 --- a/lib/librte_eventdev/rte_event_timer_adapter.h +++ b/lib/librte_eventdev/rte_event_timer_adapter.h @@ -151,6 +151,14 @@ enum rte_event_timer_adapter_clk_src { * @see struct rte_event_timer_adapter_conf::flags */ +#define RTE_EVENT_TIMER_ADAPTER_F_PERIODIC (1ULL << 2) +/**< Flag to configure an event timer adapter in periodic mode; non-periodic + * mode is the default. A timer will fire once or periodically until the timer + * is cancelled based on the adapter mode. + * + * @see struct rte_event_timer_adapter_conf::flags + */ + /** * Timer adapter configuration structure */ @@ -551,6 +559,8 @@ struct rte_event_timer_adapter { * expiry event attributes, timeout ticks from now. * This function submits the event timer arm requests to the event timer adapter * and on expiry, the events will be injected to designated event queue. + * Timer expiry events will be generated once or periodically until cancellation + * based on the adapter mode. * * @param adapter * A pointer to an event timer adapter structure. @@ -570,6 +580,9 @@ struct rte_event_timer_adapter { * destination event queue. * - EAGAIN Specified timer adapter is not running * - EALREADY A timer was encountered that was already armed + * + * @see RTE_EVENT_TIMER_ADAPTER_F_PERIODIC + * */ static inline uint16_t rte_event_timer_arm_burst(const struct rte_event_timer_adapter *adapter, diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index ce1fc2ce0f..9fc39e9ca8 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_eventdev/rte_eventdev.h @@ -1154,6 +1154,9 @@ rte_event_eth_rx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id, #define RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT (1ULL << 0) /**< This flag is set when the timer mechanism is in HW. */ +#define RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC (1ULL << 1) +/**< This flag is set if periodic mode is supported. */ + /** * Retrieve the event device's timer adapter capabilities. * -- 2.20.1