From a11dfe9b65940106e6aab62a682b12a9324b16c0 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 29 Mar 2018 14:36:20 +0100 Subject: [PATCH] net/mlx: fix warnings for unused compiler arguments When linking the mlx glue code libraries using CC, the linker arguments in LDFLAGS are not prefixed with -Wl. [The EXTRA_LDFLAGS are though.] This leads to warning messages on build: clang-5.0: warning: argument unused during compilation: '-e xport-dynamic' Fix this by checking for $LINK_USING_CC in the Makefiles and prefixing the LDFLAGS appropriately if set. Fixes: 27cea11686ff ("net/mlx4: spawn rdma-core dependency plug-in") Fixes: 59b91bec12c6 ("net/mlx5: spawn rdma-core dependency plug-in") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Yongseok Koh --- drivers/net/mlx4/Makefile | 7 ++++++- drivers/net/mlx5/Makefile | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx4/Makefile b/drivers/net/mlx4/Makefile index 8a6287f189..ac5b67f10d 100644 --- a/drivers/net/mlx4/Makefile +++ b/drivers/net/mlx4/Makefile @@ -106,8 +106,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_MLX4_DLOPEN_DEPS),y) $(LIB): $(LIB_GLUE) +ifeq ($(LINK_USING_CC),1) +GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS)) +else +GLUE_LDFLAGS := $(LDFLAGS) +endif $(LIB_GLUE): mlx4_glue.o - $Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \ + $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ -Wl,-h,$(LIB_GLUE) \ -s -shared -o $@ $< -libverbs -lmlx4 diff --git a/drivers/net/mlx5/Makefile b/drivers/net/mlx5/Makefile index 6c506a49ca..86d3afe0d6 100644 --- a/drivers/net/mlx5/Makefile +++ b/drivers/net/mlx5/Makefile @@ -157,8 +157,13 @@ ifeq ($(CONFIG_RTE_LIBRTE_MLX5_DLOPEN_DEPS),y) $(LIB): $(LIB_GLUE) +ifeq ($(LINK_USING_CC),1) +GLUE_LDFLAGS := $(call linkerprefix,$(LDFLAGS)) +else +GLUE_LDFLAGS := $(LDFLAGS) +endif $(LIB_GLUE): mlx5_glue.o - $Q $(LD) $(LDFLAGS) $(EXTRA_LDFLAGS) \ + $Q $(LD) $(GLUE_LDFLAGS) $(EXTRA_LDFLAGS) \ -Wl,-h,$(LIB_GLUE) \ -s -shared -o $@ $< -libverbs -lmlx5 -- 2.20.1