From a136b08c104afdb627b19347f15562e341ee7a1f Mon Sep 17 00:00:00 2001 From: Konstantin Ananyev Date: Fri, 22 Oct 2021 14:26:42 +0100 Subject: [PATCH] test/bonding: fix after hiding ethdev internal structures link bounding auto-test internally creates emulated ethdev. Some tests change Rx/Tx functions of this emulated device on the fly: by directly modifying rte_eth_dev fields and without doing stop/start for these devices. As now ethdev uses rte_eth_fp_ops[] for fast-path functions, these direct changes doesn't make expected effect. Fix the problem by guarding fast-path functions changes with rte_eth_dev_stop()/rte_eth_dev_start(). Fixes: 7a0935239b9e ("ethdev: make fast-path functions to use new flat array") Reported-by: Lewei Yang Signed-off-by: Konstantin Ananyev Tested-by: Ferruh Yigit --- app/test/virtual_pmd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/test/virtual_pmd.c b/app/test/virtual_pmd.c index 7e15b47eb0..ccdb418490 100644 --- a/app/test/virtual_pmd.c +++ b/app/test/virtual_pmd.c @@ -415,10 +415,14 @@ virtual_ethdev_rx_burst_fn_set_success(uint16_t port_id, uint8_t success) { struct rte_eth_dev *vrtl_eth_dev = &rte_eth_devices[port_id]; + rte_eth_dev_stop(port_id); + if (success) vrtl_eth_dev->rx_pkt_burst = virtual_ethdev_rx_burst_success; else vrtl_eth_dev->rx_pkt_burst = virtual_ethdev_rx_burst_fail; + + rte_eth_dev_start(port_id); } @@ -428,6 +432,7 @@ virtual_ethdev_tx_burst_fn_set_success(uint16_t port_id, uint8_t success) struct virtual_ethdev_private *dev_private = NULL; struct rte_eth_dev *vrtl_eth_dev = &rte_eth_devices[port_id]; + rte_eth_dev_stop(port_id); dev_private = vrtl_eth_dev->data->dev_private; if (success) @@ -436,6 +441,7 @@ virtual_ethdev_tx_burst_fn_set_success(uint16_t port_id, uint8_t success) vrtl_eth_dev->tx_pkt_burst = virtual_ethdev_tx_burst_fail; dev_private->tx_burst_fail_count = 0; + rte_eth_dev_start(port_id); } void @@ -445,7 +451,6 @@ virtual_ethdev_tx_burst_fn_set_tx_pkt_fail_count(uint16_t port_id, struct virtual_ethdev_private *dev_private = NULL; struct rte_eth_dev *vrtl_eth_dev = &rte_eth_devices[port_id]; - dev_private = vrtl_eth_dev->data->dev_private; dev_private->tx_burst_fail_count = packet_fail_count; } -- 2.20.1