From a262726ed482f3c9fba493d0bfc3b4bd53d4c432 Mon Sep 17 00:00:00 2001 From: Wisam Jaddo Date: Tue, 11 Feb 2020 15:20:06 +0200 Subject: [PATCH] net/mlx5: fix blocker for push VLAN on Rx The blocker should take FDB into consideration, since FDB all directions have transfer ingress in it. Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx") Cc: stable@dpdk.org Signed-off-by: Wisam Jaddo Acked-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index ba88325730..d88daeccbc 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t action_flags, { const struct rte_flow_action_of_push_vlan *push_vlan = action->conf; - if (attr->ingress) + if (!attr->transfer && attr->ingress) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ATTR_INGRESS, NULL, -- 2.20.1