From a29052bfeb6037dd9175c9f2cf29345be2bc2f65 Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Sat, 14 Sep 2019 11:36:59 +0200 Subject: [PATCH] net/nfb: fix dependency check The library libnfb is part of netcope-common which provides a pkg-config file: netcope-common.pc. Looking for this .pc file - with dependency() - is preferred than looking for the library - with cc.find_library(). If the library is not installed in a standard path, it can be found thanks to PKG_CONFIG_PATH variable. The previous solution required to use CFLAGS and LDFLAGS environment variables. Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver") Cc: stable@dpdk.org Signed-off-by: Thomas Monjalon Acked-by: Jan Remes --- drivers/net/nfb/meson.build | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/nfb/meson.build b/drivers/net/nfb/meson.build index 4502c3f769..d53e8eca7d 100644 --- a/drivers/net/nfb/meson.build +++ b/drivers/net/nfb/meson.build @@ -3,14 +3,9 @@ # Copyright(c) 2019 Netcope Technologies, a.s. # All rights reserved. -dep = cc.find_library('nfb', required: false) +dep = dependency('netcope-common', required: false) reason = 'missing dependency, "libnfb"' - -build = dep.found() and cc.has_header('nfb/nfb.h', dependencies: dep) - -nc = dependency('netcope-common', required: false) - +build = dep.found() ext_deps += dep -ext_deps += nc sources = files('nfb_rx.c', 'nfb_tx.c', 'nfb_stats.c', 'nfb_ethdev.c', 'nfb_rxmode.c') -- 2.20.1