From a829d41f9dd286c70e1bef26aca666473fde74fb Mon Sep 17 00:00:00 2001 From: Hiroyuki Mikita Date: Mon, 18 Jul 2016 02:35:50 +0900 Subject: [PATCH] timer: remove unnecessary list insertion When timer_set_running_state() fails in rte_timer_manage(), the failed timer is put back on pending-list. In this case, another core tries to reset or stop the timer. It does not need to be on pending-list. Fixes: a4b7a5a45cf5 ("timer: fix race condition") Signed-off-by: Hiroyuki Mikita Acked-by: Robert Sanford --- lib/librte_timer/rte_timer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c index 7457d32e27..3f21f2d53d 100644 --- a/lib/librte_timer/rte_timer.c +++ b/lib/librte_timer/rte_timer.c @@ -564,10 +564,9 @@ void rte_timer_manage(void) pprev = &tim->sl_next[0]; } else { /* another core is trying to re-config this one, - * remove it from local expired list and put it - * back on the priv_timer[] skip list */ + * remove it from local expired list + */ *pprev = next_tim; - timer_add(tim, lcore_id, 1); } } -- 2.20.1