From a8f23b444dc3ff32ff27ceeba267fe996c0fbabd Mon Sep 17 00:00:00 2001 From: Chengwen Feng Date: Fri, 17 Jun 2022 10:29:10 +0800 Subject: [PATCH] trace: fix crash when exiting Bug scenario: 1. start testpmd: $ dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* -- -i 2. quit testpmd and then observed segment fault: Bye... Segmentation fault (core dumped) The root cause is that rte_trace_save() and eal_trace_fini() access the huge pages which were cleanup by rte_eal_memory_detach(). This patch moves rte_trace_save() and eal_trace_fini() before rte_eal_memory_detach() to fix the bug. Fixes: dfbc61a2f9a6 ("mem: detach memsegs on cleanup") Cc: stable@dpdk.org Signed-off-by: Chengwen Feng Tested-by: Jerin Jacob Reviewed-by: David Marchand --- lib/eal/freebsd/eal.c | 4 ++-- lib/eal/linux/eal.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index a6b20960f2..26fbc91b26 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -893,11 +893,11 @@ rte_eal_cleanup(void) eal_get_internal_configuration(); rte_service_finalize(); rte_mp_channel_cleanup(); + rte_trace_save(); + eal_trace_fini(); /* after this point, any DPDK pointers will become dangling */ rte_eal_memory_detach(); rte_eal_alarm_cleanup(); - rte_trace_save(); - eal_trace_fini(); eal_cleanup_config(internal_conf); return 0; } diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 1ef263434a..c6f2056197 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -1266,13 +1266,13 @@ rte_eal_cleanup(void) vfio_mp_sync_cleanup(); #endif rte_mp_channel_cleanup(); + rte_trace_save(); + eal_trace_fini(); /* after this point, any DPDK pointers will become dangling */ rte_eal_memory_detach(); eal_mp_dev_hotplug_cleanup(); rte_eal_malloc_heap_cleanup(); rte_eal_alarm_cleanup(); - rte_trace_save(); - eal_trace_fini(); eal_cleanup_config(internal_conf); rte_eal_log_cleanup(); return 0; -- 2.39.5