From ab9cfe43c28efb3576396e7133af64b25b8785f3 Mon Sep 17 00:00:00 2001 From: Kuba Kozak Date: Tue, 3 Oct 2017 13:48:02 +0200 Subject: [PATCH] examples/l3fwd-acl: check fseek return Add return value check and error handling for fseek call. Coverity issue: 143435 Fixes: 361b2e9559fc ("acl: new sample l3fwd-acl") Signed-off-by: Kuba Kozak Acked-by: Konstantin Ananyev Acked-by: Zhiyong Yang --- examples/l3fwd-acl/main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c index a7f9fffe81..4d263f1cfe 100644 --- a/examples/l3fwd-acl/main.c +++ b/examples/l3fwd-acl/main.c @@ -1026,6 +1026,7 @@ add_rules(const char *rule_path, char buff[LINE_MAX]; FILE *fh = fopen(rule_path, "rb"); unsigned int i = 0; + int val; if (fh == NULL) rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, @@ -1042,7 +1043,11 @@ add_rules(const char *rule_path, rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n", rule_path); - fseek(fh, 0, SEEK_SET); + val = fseek(fh, 0, SEEK_SET); + if (val < 0) { + rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n", + __func__); + } acl_rules = calloc(acl_num, rule_size); -- 2.20.1