From af093c6301f15fbf7cf86ecaa1ae5da5a5edfda1 Mon Sep 17 00:00:00 2001 From: Olivier Matz Date: Thu, 1 Mar 2018 15:21:28 +0100 Subject: [PATCH] don't use atoi --- lib/ecoli_node_expr_test.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/ecoli_node_expr_test.c b/lib/ecoli_node_expr_test.c index f14cf50..a26fe08 100644 --- a/lib/ecoli_node_expr_test.c +++ b/lib/ecoli_node_expr_test.c @@ -51,7 +51,9 @@ ec_node_expr_test_eval_var(void **result, void *userctx, const struct ec_parsed *var) { const struct ec_strvec *vec; - struct my_eval_result *eval; + const struct ec_node *node; + struct my_eval_result *eval = NULL; + int64_t val; (void)userctx; @@ -60,11 +62,15 @@ ec_node_expr_test_eval_var(void **result, void *userctx, if (ec_strvec_len(vec) != 1) return -EINVAL; + node = ec_parsed_get_node(var); + if (ec_node_int_getval(node, ec_strvec_val(vec, 0), &val) < 0) + return -EINVAL; + eval = ec_malloc(sizeof(*eval)); if (eval == NULL) return -ENOMEM; - eval->val = atoi(ec_strvec_val(vec, 0)); // XXX use strtol + eval->val = val; printf("eval var %d\n", eval->val); *result = eval; -- 2.20.1