From af316ecf58dc4aa6bdc3665ed32854a4a3a3089a Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Mon, 6 Feb 2017 10:59:37 +0530 Subject: [PATCH] eventdev: limit port link operation to configured queues On port_setup, the link_map is updated only for configured number of event queues. Limit the port_links_get scan only to configured number of event queues. Also, Limit the port link and unlink queue validation to configured number of event queues. Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") Reported-by: Nipun Gupta Signed-off-by: Jerin Jacob Acked-by: Nipun Gupta --- lib/librte_eventdev/rte_eventdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev.c b/lib/librte_eventdev/rte_eventdev.c index 91bd1c9437..68bfc3b65d 100644 --- a/lib/librte_eventdev/rte_eventdev.c +++ b/lib/librte_eventdev/rte_eventdev.c @@ -798,7 +798,7 @@ rte_event_port_link(uint8_t dev_id, uint8_t port_id, } for (i = 0; i < nb_links; i++) - if (queues[i] >= RTE_EVENT_MAX_QUEUES_PER_DEV) + if (queues[i] >= dev->data->nb_queues) return -EINVAL; diag = (*dev->dev_ops->port_link)(dev, dev->data->ports[port_id], @@ -843,7 +843,7 @@ rte_event_port_unlink(uint8_t dev_id, uint8_t port_id, } for (i = 0; i < nb_unlinks; i++) - if (queues[i] >= RTE_EVENT_MAX_QUEUES_PER_DEV) + if (queues[i] >= dev->data->nb_queues) return -EINVAL; diag = (*dev->dev_ops->port_unlink)(dev, dev->data->ports[port_id], @@ -879,7 +879,7 @@ rte_event_port_links_get(uint8_t dev_id, uint8_t port_id, links_map = dev->data->links_map; /* Point links_map to this port specific area */ links_map += (port_id * RTE_EVENT_MAX_QUEUES_PER_DEV); - for (i = 0; i < RTE_EVENT_MAX_QUEUES_PER_DEV; i++) { + for (i = 0; i < dev->data->nb_queues; i++) { if (links_map[i] != EVENT_QUEUE_SERVICE_PRIORITY_INVALID) { queues[count] = i; priorities[count] = (uint8_t)links_map[i]; -- 2.20.1