From af397b3c93f82b0803c0890874d7ee3b5127522d Mon Sep 17 00:00:00 2001 From: Hyong Youb Kim Date: Mon, 25 Oct 2021 17:04:18 -0700 Subject: [PATCH] net/enic: avoid error message when no advanced filtering Probing the availability of Flow Manager API may print the following error log. PMD: rte_enic_pmd: Devcmd 88 failed with error code -1 The error indicates a flow manager operation failed and happens when advanced filtering is disabled on vNIC. It is harmless but confusing to the user. Since advanced filtering is a prerequisite, check first if it is available and avoid the error message altogether. Fixes: ea7768b5bba8 ("net/enic: add flow implementation based on Flow Manager API") Cc: stable@dpdk.org Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- drivers/net/enic/base/vnic_dev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/enic/base/vnic_dev.c b/drivers/net/enic/base/vnic_dev.c index 9c42595ced..00d7782e6e 100644 --- a/drivers/net/enic/base/vnic_dev.c +++ b/drivers/net/enic/base/vnic_dev.c @@ -594,6 +594,9 @@ static int vnic_dev_flowman_enable(struct vnic_dev *vdev, uint32_t *mode, uint64_t ops; static uint32_t instance; + /* Advanced filtering is a prerequisite */ + if (!vnic_dev_capable_adv_filters(vdev)) + return 0; /* flowman devcmd available? */ if (!vnic_dev_capable(vdev, CMD_FLOW_MANAGER_OP)) return 0; -- 2.39.5