From afda6b01164dc83f71a684b94c0c9d096281caad Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Fri, 30 Oct 2020 15:37:00 +0000 Subject: [PATCH] examples/fips_validation: fix crash on allocation failure The return value was not being checked when calling the get_writeback_data function in the AES test case. On failure, this led to a NULL dereference when using memcpy later. The return value is now checked to avoid this NULL dereference. Coverity issue: 363463 Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list") Signed-off-by: Ciara Power Reviewed-by: David Marchand --- examples/fips_validation/main.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c index 07532c9562..6a1cea36f5 100644 --- a/examples/fips_validation/main.c +++ b/examples/fips_validation/main.c @@ -1520,7 +1520,9 @@ fips_mct_aes_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; if (info.op == FIPS_TEST_DEC_AUTH_VERIF) memcpy(prev_in, vec.ct.val, AES_BLOCK_SIZE); @@ -1649,7 +1651,9 @@ fips_mct_sha_test(void) return ret; } - get_writeback_data(&val); + ret = get_writeback_data(&val); + if (ret < 0) + return ret; memcpy(md[0].val, md[1].val, md[1].len); md[0].len = md[1].len; -- 2.20.1