From b23fd370cd5b84228d453e52931eaa5cd3f2846c Mon Sep 17 00:00:00 2001 From: Gaetan Rivet Date: Mon, 16 Nov 2020 11:12:12 +0100 Subject: [PATCH] bus/pci: fix comment explaining device naming The original triple negative was hard to read and the attempt to improve the formulation was commendable, unfortunately the new comment is the inverse of correct. Fixes: a65a34a85ebf ("eal: replace usage of blacklist/whitelist in enums") Reported-by: David Marchand Signed-off-by: Gaetan Rivet Acked-by: Luca Boccassi Reviewed-by: David Marchand --- drivers/bus/pci/pci_common.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index b24c069713..9b8d769287 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -68,7 +68,9 @@ pci_name_set(struct rte_pci_device *dev) devargs = pci_devargs_lookup(&dev->addr); dev->device.devargs = devargs; - /* If the device is blocked, no rte_devargs exists for it. */ + /* When using a blocklist, only blocked devices will have + * an rte_devargs. Allowed devices won't have one. + */ if (devargs != NULL) /* If an rte_devargs exists, the generic rte_device uses the * given name as its name. -- 2.20.1