From b6aadd7436bfc1fb2af67aa266588fdd80ca8988 Mon Sep 17 00:00:00 2001 From: Rosen Xu Date: Tue, 23 Oct 2018 09:50:49 +0800 Subject: [PATCH] raw/ifpga: check probing error Fixes not checking rte_eal_hotplug_add() return value issue. Coverity issue: 323508 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Cc: stable@dpdk.org Signed-off-by: Rosen Xu Acked-by: Shreyansh Jain --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c index 3fed05781e..32e318fc3d 100644 --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c @@ -542,6 +542,7 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) int port; char *name = NULL; char dev_name[RTE_RAWDEV_NAME_MAX_LEN]; + int ret = -1; devargs = dev->device.devargs; @@ -583,7 +584,7 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) snprintf(dev_name, RTE_RAWDEV_NAME_MAX_LEN, "%d|%s", port, name); - rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), + ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), dev_name, devargs->args); end: if (kvlist) @@ -591,7 +592,7 @@ end: if (name) free(name); - return 0; + return ret; } static int -- 2.20.1