From b6e029cfa4ad1bca4244e81d23835406e54fa352 Mon Sep 17 00:00:00 2001 From: Wei Huang Date: Wed, 22 Jun 2022 23:11:30 -0400 Subject: [PATCH] raw/ifpga/base: check null pointer in PMCI Do null-checking on hw->adapter in fme_pmci_init() before dereference it. Coverity issue: 379202 Fixes: ca6eb0f7c836 ("raw/ifpga/base: add PMCI base driver") Signed-off-by: Wei Huang Acked-by: Tianfei Zhang Acked-by: Rosen Xu --- drivers/raw/ifpga/base/ifpga_fme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c index 25ff819955..b6dd4ce58c 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -1591,7 +1591,7 @@ static int fme_pmci_init(struct ifpga_feature *feature) int ret = 0; hw = fme->parent; - if (!hw) + if (!hw || !hw->adapter) return -ENODEV; mgr = hw->adapter->mgr; @@ -1608,7 +1608,7 @@ static int fme_pmci_init(struct ifpga_feature *feature) max10->type = M10_N6000; max10->mmio = feature->addr; - if (hw->adapter && hw->adapter->shm.ptr) { + if (hw->adapter->shm.ptr) { sd = (opae_share_data *)hw->adapter->shm.ptr; max10->bmc_ops.mutex = &sd->spi_mutex; } else { -- 2.39.5