From b7c8ea62d00f02c206ec2aded5581c2e0f01c377 Mon Sep 17 00:00:00 2001 From: Dmitry Kozlyuk Date: Wed, 21 Jul 2021 15:51:12 +0300 Subject: [PATCH] net/mlx5: fix indirect action modify rollback mlx5_ind_table_obj_modify() first references queues from the new list, then applies the new list to HW. In case of apply failure the function dereferenced queues from the old list, while it should be the new list. Fixes: fa7ad49e96b5 ("net/mlx5: fix shared RSS action update") Cc: stable@dpdk.org Signed-off-by: Dmitry Kozlyuk Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 4a8b67e731..49165f482e 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2086,7 +2086,7 @@ mlx5_ind_table_obj_modify(struct rte_eth_dev *dev, error: err = rte_errno; for (j = 0; j < i; j++) - mlx5_rxq_release(dev, ind_tbl->queues[j]); + mlx5_rxq_release(dev, queues[j]); rte_errno = err; DRV_LOG(DEBUG, "Port %u cannot setup indirection table.", dev->data->port_id); -- 2.20.1