From baa4f61a35e8cf2f1ac23b7aa45f28a86e3791a9 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 22 Jul 2019 17:58:32 +0100 Subject: [PATCH] app/testpmd: fix MAC address parser for flow rule MAC address parsing was causing failure [1], this patch partially reverts the commit commit b5ddce8959b2 ("app/testpmd: use new ethernet address parser") [1] testpmd> flow validate 0 priority 2 ingress group 0 pattern eth dst is 98:03:9B:5C:D9:00 / end actions queue index 0 / end Bad arguments Fixes: b5ddce8959b2 ("app/testpmd: use new ethernet address parser") Reported-by: Raslan Darawsheh Signed-off-by: Ferruh Yigit Tested-by: Raslan Darawsheh --- app/test-pmd/cmdline_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index d08f016bec..495871394e 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include "testpmd.h" @@ -4978,8 +4979,8 @@ parse_mac_addr(struct context *ctx, const struct token *token, /* Only network endian is supported. */ if (!arg->hton) goto error; - ret = rte_ether_unformat_addr(str, &tmp); - if (ret < 0) + ret = cmdline_parse_etheraddr(NULL, str, &tmp, size); + if (ret < 0 || (unsigned int)ret != len) goto error; if (!ctx->object) return len; -- 2.20.1