From be939f60f42673eaa99609ea2c9f876e29320eff Mon Sep 17 00:00:00 2001 From: Xueming Li Date: Fri, 16 Mar 2018 23:22:27 +0800 Subject: [PATCH] net/mlx5: fix existing file removal There is no guarantee that the file won't be removed by external user/application between the stat() and remove() syscalls, remove() will fail if the file no longer exists. Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor") Cc: stable@dpdk.org Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_socket.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c index 955306d29d..7ce2ebceef 100644 --- a/drivers/net/mlx5/mlx5_socket.c +++ b/drivers/net/mlx5/mlx5_socket.c @@ -33,7 +33,6 @@ mlx5_socket_init(struct rte_eth_dev *dev) }; int ret; int flags; - struct stat file_stat; /* * Initialise the socket to communicate with the secondary @@ -59,9 +58,7 @@ mlx5_socket_init(struct rte_eth_dev *dev) } snprintf(sun.sun_path, sizeof(sun.sun_path), "/var/tmp/%s_%d", MLX5_DRIVER_NAME, priv->primary_socket); - ret = stat(sun.sun_path, &file_stat); - if (!ret) - claim_zero(remove(sun.sun_path)); + remove(sun.sun_path); ret = bind(priv->primary_socket, (const struct sockaddr *)&sun, sizeof(sun)); if (ret < 0) { -- 2.20.1