From c05c22f9b8032c2974de7042ba8c38fb42ed7c82 Mon Sep 17 00:00:00 2001 From: Kalesh AP Date: Tue, 4 Jan 2022 14:08:23 +0530 Subject: [PATCH] net/bnxt: fix xstats query Fix incorrect memset in bnxt_dev_xstats_get_op. In bnxt_dev_xstats_get_op(), the PMD is not zeroing the whole buffer supplied by the application. This can end up passing junk statistics values to the application when the FW does not support extended stats on a function. Fixed to call memset() with correct size. Fixes: f55e12f33416 ("net/bnxt: support extended port counters") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 197fd7c02b..208aa5616d 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -741,7 +741,7 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, (bp->fw_tx_port_stats_ext_size / stat_size)); - memset(xstats, 0, sizeof(*xstats)); + memset(xstats, 0, sizeof(*xstats) * n); count = 0; for (i = 0; i < RTE_DIM(bnxt_rx_stats_strings); i++) { -- 2.39.5