From c629829f026dd0215db30a34fadfef3830932dd6 Mon Sep 17 00:00:00 2001 From: Jie Pan Date: Wed, 10 Apr 2019 14:20:55 +0800 Subject: [PATCH] kni: fix type for MAC address The type for MAC address should be unsigned. Fixes: 1cfe212ed17a ("kni: support MAC address change") Cc: stable@dpdk.org Signed-off-by: Jie Pan Acked-by: Ferruh Yigit Reviewed-by: Rami Rosen --- kernel/linux/kni/kni_misc.c | 2 +- lib/librte_eal/linux/eal/include/rte_kni_common.h | 2 +- lib/librte_kni/rte_kni.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/linux/kni/kni_misc.c b/kernel/linux/kni/kni_misc.c index 31845e10f9..b6f474de4d 100644 --- a/kernel/linux/kni/kni_misc.c +++ b/kernel/linux/kni/kni_misc.c @@ -447,7 +447,7 @@ kni_ioctl_create(struct net *net, uint32_t ioctl_num, ether_addr_copy(net_dev->dev_addr, kni->lad_dev->dev_addr); else { /* if user has provided a valid mac address */ - if (is_valid_ether_addr((unsigned char *)(dev_info.mac_addr))) + if (is_valid_ether_addr(dev_info.mac_addr)) memcpy(net_dev->dev_addr, dev_info.mac_addr, ETH_ALEN); else /* diff --git a/lib/librte_eal/linux/eal/include/rte_kni_common.h b/lib/librte_eal/linux/eal/include/rte_kni_common.h index 5afa087131..5db5a13335 100644 --- a/lib/librte_eal/linux/eal/include/rte_kni_common.h +++ b/lib/librte_eal/linux/eal/include/rte_kni_common.h @@ -127,7 +127,7 @@ struct rte_kni_device_info { /* mbuf size */ unsigned mbuf_size; unsigned int mtu; - char mac_addr[6]; + uint8_t mac_addr[6]; }; #define KNI_DEVICE "kni" diff --git a/lib/librte_kni/rte_kni.h b/lib/librte_kni/rte_kni.h index 9a9a7d7543..c93d3a9854 100644 --- a/lib/librte_kni/rte_kni.h +++ b/lib/librte_kni/rte_kni.h @@ -68,7 +68,7 @@ struct rte_kni_conf { __extension__ uint8_t force_bind : 1; /* Flag to bind kernel thread */ - char mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ + uint8_t mac_addr[ETHER_ADDR_LEN]; /* MAC address assigned to KNI */ uint16_t mtu; }; -- 2.20.1