From cfe4ca10210b6f2d5fce5f423681e69c1a4fa86f Mon Sep 17 00:00:00 2001 From: David Marchand Date: Wed, 8 Jul 2020 11:40:46 +0200 Subject: [PATCH] devtools: give some hints for ABI errors abidiff can provide some more information about the ABI difference it detected. In all cases, a discussion on the mailing must happen but we can give some hints to know if this is a problem with the script calling abidiff, a potential ABI breakage or an unambiguous ABI breakage. Signed-off-by: David Marchand Acked-by: Ray Kinsella Acked-by: Neil Horman Acked-by: Aaron Conole --- devtools/check-abi.sh | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh index e17fedbd9f..ab6748cfbc 100755 --- a/devtools/check-abi.sh +++ b/devtools/check-abi.sh @@ -50,10 +50,22 @@ for dump in $(find $refdir -name "*.dump"); do error=1 continue fi - if ! abidiff $ABIDIFF_OPTIONS $dump $dump2; then + abidiff $ABIDIFF_OPTIONS $dump $dump2 || { + abiret=$? echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" error=1 - fi + echo + if [ $(($abiret & 3)) -ne 0 ]; then + echo "ABIDIFF_ERROR|ABIDIFF_USAGE_ERROR, this could be a script or environment issue." + fi + if [ $(($abiret & 4)) -ne 0 ]; then + echo "ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged this as a potential issue)." + fi + if [ $(($abiret & 8)) -ne 0 ]; then + echo "ABIDIFF_ABI_INCOMPATIBLE_CHANGE, this change breaks the ABI." + fi + echo + } done [ -z "$error" ] || [ -n "$warnonly" ] -- 2.20.1