From d49bdfcf0db9f03131fa377f959c807524959b35 Mon Sep 17 00:00:00 2001 From: Sunil Kumar Kori Date: Tue, 29 Mar 2022 15:58:57 +0530 Subject: [PATCH] net/cnxk: fix crash during hotplug detach operation hot_plug application does not perform any port setup configuration via rte_eth_dev_configure() API. All the probed Ethernet ports do not contain any Rx and Tx queues. While detaching a device via rte_eal_hotplug_remove(), CNXK driver expects Rx and Tx queues structures populated during reset of PFC. So application gets crashed as data->rx_queues and data->tx_queues are NULL. Fixes: 9544713564f5 ("net/cnxk: support priority flow control") Cc: stable@dpdk.org Signed-off-by: Sunil Kumar Kori Acked-by: Jerin Jacob --- drivers/net/cnxk/cnxk_ethdev_ops.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c index f4a0562475..15d8e8efa6 100644 --- a/drivers/net/cnxk/cnxk_ethdev_ops.c +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c @@ -1069,6 +1069,11 @@ nix_priority_flow_ctrl_configure(struct rte_eth_dev *eth_dev, rx_pause = (mode == RTE_ETH_FC_FULL) || (mode == RTE_ETH_FC_RX_PAUSE); tx_pause = (mode == RTE_ETH_FC_FULL) || (mode == RTE_ETH_FC_TX_PAUSE); + if (data->rx_queues == NULL || data->tx_queues == NULL) { + rc = 0; + goto exit; + } + /* Configure CQs */ memset(&fc_cfg, 0, sizeof(struct roc_nix_fc_cfg)); rxq = ((struct cnxk_eth_rxq_sp *)data->rx_queues[conf->rx_qid]) - 1; -- 2.20.1