From d4bda0ab2972cb3fd65fbb2575a51de5a68757cb Mon Sep 17 00:00:00 2001 From: Flavia Musatescu Date: Fri, 18 Oct 2019 15:24:31 +0100 Subject: [PATCH] net/af_packet: improve Tx statistics accuracy When sendto call fails and ENOBUFS/EAGAIN error is being set some of the packets are actually successfully transmitted. There is no available count of those packets, so in order to make the statistics more accurate, all the previously enqueued packets will be considered successful, even though this is not entirely correct. Statistics numbers before this update: Pktgen: Total Rx Pkts: 1360084 Tx Pkts: 2000000 testpmd: RX-packets: 1408346 RX-missed: 0 RX-bytes: 84503418 TX-packets: 526486 TX-errors: 881851 TX-bytes: 31589724 Statistics numbers after this update: Pktgen: Total Rx Pkts: 1329872 Tx Pkts: 2000000 testpmd: RX-packets: 1389156 RX-missed: 0 RX-bytes: 83349360 TX-packets: 1389156 TX-errors: 0 TX-bytes: 83349360 Fixes: 74b7fc0a0ff1 ("net/af_packet: fix packet bytes counting") Cc: stable@dpdk.org Signed-off-by: Flavia Musatescu Reviewed-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index dce76b04e5..5b71db7078 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -244,8 +244,14 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) } /* kick-off transmits */ - if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1) { - /* error sending -- no packets transmitted */ + if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1 && + errno != ENOBUFS && errno != EAGAIN) { + /* + * In case of a ENOBUFS/EAGAIN error all of the enqueued + * packets will be considered successful even though only some + * are sent. + */ + num_tx = 0; num_tx_bytes = 0; } -- 2.20.1