From d62be9ce13bd328952bdeeb81f3942956f978fbe Mon Sep 17 00:00:00 2001 From: Simei Su Date: Thu, 14 Jan 2021 13:23:24 +0800 Subject: [PATCH] net/iavf: fix null pointer dereference in eCPRI rule A pointer has already been dereferenced before checking if it is NULL. It doesn't make any sense, so correct to avoid it. Coverity issue: 365290 Fixes: f57ebdae3cd0 ("net/iavf: support eCPRI message type 0 for RSS") Signed-off-by: Simei Su Acked-by: Qi Zhang --- drivers/net/iavf/iavf_hash.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index ebaac58254..958c73c4fb 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -597,11 +597,12 @@ iavf_hash_parse_pattern(const struct rte_flow_item pattern[], uint64_t *phint, break; case RTE_FLOW_ITEM_TYPE_ECPRI: ecpri = item->spec; - ecpri_common.u32 = rte_be_to_cpu_32( - ecpri->hdr.common.u32); if (!ecpri) break; - else if (ecpri_common.type != + + ecpri_common.u32 = rte_be_to_cpu_32(ecpri->hdr.common.u32); + + if (ecpri_common.type != RTE_ECPRI_MSG_TYPE_IQ_DATA) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM, item, -- 2.20.1