From d6dccbd76692c64cff79a821bc73069dc5b043e4 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Fri, 14 Jan 2022 12:46:44 -0800 Subject: [PATCH] net/memif: remove unnecessary Rx interrupt stub MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Reviewed-by: Ferruh Yigit --- drivers/net/memif/rte_eth_memif.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c index 59cb5a82a2..d3459c5007 100644 --- a/drivers/net/memif/rte_eth_memif.c +++ b/drivers/net/memif/rte_eth_memif.c @@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev) return 0; } -static int -memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused, - uint16_t qid __rte_unused) -{ - MIF_LOG(WARNING, "Interrupt mode not supported."); - - return -1; -} - -static int -memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused) -{ - struct pmd_internals *pmd __rte_unused = dev->data->dev_private; - - return 0; -} - static const struct eth_dev_ops ops = { .dev_start = memif_dev_start, .dev_stop = memif_dev_stop, @@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = { .rx_queue_setup = memif_rx_queue_setup, .rx_queue_release = memif_rx_queue_release, .tx_queue_release = memif_tx_queue_release, - .rx_queue_intr_enable = memif_rx_queue_intr_enable, - .rx_queue_intr_disable = memif_rx_queue_intr_disable, .link_update = memif_link_update, .stats_get = memif_stats_get, .stats_reset = memif_stats_reset, -- 2.20.1