From d97428bfb94c77921bda8e688ff745b0dcab0abc Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Mon, 10 May 2021 14:11:48 +0800 Subject: [PATCH] app/eventdev: remove unnecessary barrier from order test For "order_launch_lcores" function, wmb after that the main lcore updates the variable "t->err", which represents the end of the test signal, is unnecessary. Because after the main lcore updates this signal variable, it will jump out of the launch function loop, and wait other lcores stop or return error in the main function(evt_main.c). During this time, there is no storing operation and thus no need for wmb. Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli Acked-by: Jerin Jacob --- app/test-eventdev/test_order_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c index 04456d56db..d7760061ba 100644 --- a/app/test-eventdev/test_order_common.c +++ b/app/test-eventdev/test_order_common.c @@ -308,7 +308,6 @@ order_launch_lcores(struct evt_test *test, struct evt_options *opt, rte_event_dev_dump(opt->dev_id, stdout); evt_err("No schedules for seconds, deadlock"); t->err = true; - rte_smp_wmb(); break; } old_remaining = remaining; -- 2.20.1