From df07aa22d1eb45f6077473adf967a2941a584cbe Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 25 Oct 2021 22:14:32 -0700 Subject: [PATCH] net/bnxt: fix RSS action parser Minor fixes are needed in the RTE_FLOW RSS action parser. 1. Update the comment in the parser to indicate RSS level 1 implies RSS on outer header. 2. RSS action will not be supported if level is > 1. 3. RSS action will not be supported if user or application specifies MARK or COUNT action. 4. If RSS types is not specified i.e., is 0, the best effort RSS should use IPv4 and IPv6 headers. Currently we are considering only IPv4. Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") Signed-off-by: Ajit Khaparde Acked-by: Kalesh AP Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt_flow.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index ced697a739..09b1342533 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -1084,10 +1084,6 @@ bnxt_validate_rss_action(const struct rte_flow_action actions[]) break; case RTE_FLOW_ACTION_TYPE_RSS: break; - case RTE_FLOW_ACTION_TYPE_MARK: - break; - case RTE_FLOW_ACTION_TYPE_COUNT: - break; default: return -ENOTSUP; } @@ -1151,11 +1147,10 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, } /* Currently RSS hash on inner and outer headers are supported. - * 0 => Default setting - * 1 => Inner - * 2 => Outer + * 0 => Default (innermost RSS) setting + * 1 => Outermost */ - if (rss->level > 2) { + if (rss->level > 1) { rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, @@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, } /* If RSS types is 0, use a best effort configuration */ - types = rss->types ? rss->types : RTE_ETH_RSS_IPV4; + types = rss->types ? rss->types : RTE_ETH_RSS_IPV4 | RTE_ETH_RSS_IPV6; hash_type = bnxt_rte_to_hwrm_hash_types(types); -- 2.39.5