From e07f80c850f2c253e1ac0b39c4956af12f100d47 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Fri, 27 May 2016 13:06:20 +0100 Subject: [PATCH] net/pcap: fix crash on close Testpmd application will crash in fclose() upon quit after running the below command. "sudo gdb --args ./x86_64-native-linuxapp-gcc/app/testpmd -c 0xf0 -n 4 --vdev 'eth_pcap0,tx_iface=enp1s0f1,rx_pcap=/tmp/test.pcap' -- --port-topology=chained -i" The reason is, pcap vdev creation with tx stream type as "iface" as in above command doesn't need member "dumpers" of "struct tx_pcaps", hence will not have memory allocated for it. It contains a garbage values, as local object of struct tx_pcaps is not initialized to 0 inside rte_pmd_pcap_dev_init(). So calling pcap_dump_close() on dumper as part of eth_dev_stop() is causing segfault in fclose(). Fix is to initialize local object of struct tx_pcaps to 0. Also initialize local object of struct rx_pcaps to 0. So during eth_dev_stop(), pcap_dump_close() will not be called if dumper is NULL. Fixes: 4c173302c307 ("pcap: add new driver") Signed-off-by: Reshma Pattan Acked-by: Ferruh Yigit --- drivers/net/pcap/rte_eth_pcap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c index c98e234151..c86f17b64d 100644 --- a/drivers/net/pcap/rte_eth_pcap.c +++ b/drivers/net/pcap/rte_eth_pcap.c @@ -978,8 +978,8 @@ rte_pmd_pcap_devinit(const char *name, const char *params) unsigned numa_node, using_dumpers = 0; int ret; struct rte_kvargs *kvlist; - struct rx_pcaps pcaps; - struct tx_pcaps dumpers; + struct rx_pcaps pcaps = {0}; + struct tx_pcaps dumpers = {0}; RTE_LOG(INFO, PMD, "Initializing pmd_pcap for %s\n", name); -- 2.20.1