From e1a803ba43b99f4fb4e3f6212aea7b46c4ebf3e8 Mon Sep 17 00:00:00 2001 From: Wenjun Wu Date: Mon, 15 Mar 2021 08:59:53 +0800 Subject: [PATCH] net/iavf: fix RSS hash update This patch change judgment statements to disable RSS for vf when users need to disable RSS or RSS hash function configured is not supported. Fixes: 95f2f0e9fc2a ("net/iavf: improve default RSS") Cc: stable@dpdk.org Signed-off-by: Wenjun Wu Acked-by: Qi Zhang --- drivers/net/iavf/iavf_ethdev.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 4d37722022..8610efba6d 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -1250,8 +1250,17 @@ iavf_dev_rss_hash_update(struct rte_eth_dev *dev, if (ret) return ret; - if (rss_conf->rss_hf == 0) + if (rss_conf->rss_hf == 0) { + vf->rss_hf = 0; + ret = iavf_set_hena(adapter, 0); + + /* It is a workaround, temporarily allow error to be returned + * due to possible lack of PF handling for hena = 0. + */ + if (ret) + PMD_DRV_LOG(WARNING, "fail to clean existing RSS, lack PF support"); return 0; + } if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) { /* Clear existing RSS. */ -- 2.20.1