From e34e2f55a793c8393fb34afc5b0e19518c713e65 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 25 Mar 2021 13:57:05 +0000 Subject: [PATCH] telemetry: make the legacy registration function internal The function for registration of callbacks for legacy telemetry was documented as internal-only in the API documents, but marked as experimental in the version.map file. Since this is an internal-only function, for consistency we update the version mapping to have it as internal. Signed-off-by: Bruce Richardson Acked-by: Ciara Power --- doc/guides/rel_notes/release_21_05.rst | 5 +++++ lib/librte_telemetry/rte_telemetry_legacy.h | 2 +- lib/librte_telemetry/version.map | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/doc/guides/rel_notes/release_21_05.rst b/doc/guides/rel_notes/release_21_05.rst index 8e686cc627..fb965fec32 100644 --- a/doc/guides/rel_notes/release_21_05.rst +++ b/doc/guides/rel_notes/release_21_05.rst @@ -148,6 +148,11 @@ ABI Changes * No ABI change that would break compatibility with 20.11. +* The experimental function ``rte_telemetry_legacy_register`` has been + removed from the public API and is now an internal-only function. This + function was already marked as internal in the API documentation for it, + and was not for use by external applications. + Known Issues ------------ diff --git a/lib/librte_telemetry/rte_telemetry_legacy.h b/lib/librte_telemetry/rte_telemetry_legacy.h index c83f9a8d90..fb44740186 100644 --- a/lib/librte_telemetry/rte_telemetry_legacy.h +++ b/lib/librte_telemetry/rte_telemetry_legacy.h @@ -78,7 +78,7 @@ legacy_client_handler(void *sock_id); * @return * -ENOENT if max callbacks limit has been reached. */ -__rte_experimental +__rte_internal int rte_telemetry_legacy_register(const char *cmd, enum rte_telemetry_legacy_data_req data_req, diff --git a/lib/librte_telemetry/version.map b/lib/librte_telemetry/version.map index ec0ebc1bec..bde80ce29b 100644 --- a/lib/librte_telemetry/version.map +++ b/lib/librte_telemetry/version.map @@ -14,12 +14,12 @@ EXPERIMENTAL { rte_tel_data_start_array; rte_tel_data_start_dict; rte_tel_data_string; - rte_telemetry_legacy_register; rte_telemetry_register_cmd; local: *; }; INTERNAL { + rte_telemetry_legacy_register; rte_telemetry_init; }; -- 2.20.1