From e690338a7b8549679deb257c3a3f576fb900d509 Mon Sep 17 00:00:00 2001 From: Rami Rosen Date: Sun, 20 May 2018 22:52:58 +0300 Subject: [PATCH] bus/pci: remove unused function to detach by address The function rte_pci_detach() is private to PCI and is not used anywhere in current code base. Remove dead code. Signed-off-by: Rami Rosen --- drivers/bus/pci/pci_common.c | 37 ------------------------------------ drivers/bus/pci/private.h | 15 --------------- 2 files changed, 52 deletions(-) diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c index 8127f58166..d8151b0911 100644 --- a/drivers/bus/pci/pci_common.c +++ b/drivers/bus/pci/pci_common.c @@ -257,43 +257,6 @@ pci_probe_all_drivers(struct rte_pci_device *dev) return 1; } -/* - * Detach device specified by its pci address. - */ -int -rte_pci_detach(const struct rte_pci_addr *addr) -{ - struct rte_pci_device *dev = NULL; - int ret = 0; - - if (addr == NULL) - return -1; - - FOREACH_DEVICE_ON_PCIBUS(dev) { - if (rte_pci_addr_cmp(&dev->addr, addr)) - continue; - - ret = rte_pci_detach_dev(dev); - if (ret < 0) - /* negative value is an error */ - goto err_return; - if (ret > 0) - /* positive value means driver doesn't support it */ - continue; - - rte_pci_remove_device(dev); - free(dev); - return 0; - } - return -1; - -err_return: - RTE_LOG(WARNING, EAL, "Requested device " PCI_PRI_FMT - " cannot be used\n", dev->addr.domain, dev->addr.bus, - dev->addr.devid, dev->addr.function); - return -1; -} - /* * Scan the content of the PCI bus, and call the probe() function for * all registered drivers that have a matching entry in its id_table diff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h index 353a1aba0e..8ddd03e16c 100644 --- a/drivers/bus/pci/private.h +++ b/drivers/bus/pci/private.h @@ -32,21 +32,6 @@ rte_pci_probe(void); */ int rte_pci_scan(void); -/** - * Close the single PCI device. - * - * Scan the content of the PCI bus, and find the pci device specified by pci - * address, then call the remove() function for registered driver that has a - * matching entry in its id_table for discovered device. - * - * @param addr - * The PCI Bus-Device-Function address to close. - * @return - * - 0 on success. - * - Negative on error. - */ -int rte_pci_detach(const struct rte_pci_addr *addr); - /** * Find the name of a PCI device. */ -- 2.20.1