From e6bea83ee3ba49123eb26f6442b9cd27b4ec6215 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Tue, 24 Oct 2017 16:19:47 -0500 Subject: [PATCH] net/bnxt: fix a pointer deref before null check Coverity issue: 195015 Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 9065a12dfc..c2d54efd89 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2039,6 +2039,11 @@ bnxt_cfg_ntuple_filter(struct bnxt *bp, goto free_filter; STAILQ_INSERT_TAIL(&vnic->filter, bfilter, next); } else { + if (mfilter == NULL) { + /* This should not happen. But for Coverity! */ + ret = -ENOENT; + goto free_filter; + } ret = bnxt_hwrm_clear_ntuple_filter(bp, mfilter); STAILQ_REMOVE(&vnic->filter, mfilter, bnxt_filter_info, -- 2.20.1