From e74ac669847982129a555834217c2a412eac32e6 Mon Sep 17 00:00:00 2001 From: =?utf8?q?N=C3=A9lio=20Laranjeiro?= Date: Fri, 27 Jan 2017 16:35:19 +0100 Subject: [PATCH] net/mlx5: fix flow pattern VLAN validation TCI field is read from the wrong place due to an invalid cast. Moreover there is no need to limit matching to VID since PCP and DEI bits can be matched as well. Fixes: 12475fb203ad ("net/mlx5: support VLAN flow item") Signed-off-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7b97a610ee..d805c0aa8f 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -410,17 +410,6 @@ priv_flow_validate(struct priv *priv, if (items->type == RTE_FLOW_ITEM_TYPE_VOID) continue; - /* Handle special situation for VLAN. */ - if (items->type == RTE_FLOW_ITEM_TYPE_VLAN) { - if (((const struct rte_flow_item_vlan *)items)->tci > - ETHER_MAX_VLAN_ID) { - rte_flow_error_set(error, ENOTSUP, - RTE_FLOW_ERROR_TYPE_ITEM, - items, - "wrong VLAN id value"); - return -rte_errno; - } - } for (i = 0; cur_item->items && cur_item->items[i] != RTE_FLOW_ITEM_TYPE_END; -- 2.20.1