From e8a197d2aa9a7375961a1e7356dfc5265a382158 Mon Sep 17 00:00:00 2001 From: "John W. Linville" Date: Thu, 29 Sep 2016 13:39:34 -0400 Subject: [PATCH] net/bnxt: ensure entry length is unsigned Otherwise, the inherent cast when multiplying entry_length by max_vnics in the call to rte_memzone_reserve could promote max_vnics to a signed value, causing hilarity to ensue... Coverity issue: 127557 Fixes: 9738793f28ec ("net/bnxt: add VNIC functions and structs") Signed-off-by: John W. Linville Acked-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_vnic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c index 6297e87365..205a940d14 100644 --- a/drivers/net/bnxt/bnxt_vnic.c +++ b/drivers/net/bnxt/bnxt_vnic.c @@ -175,7 +175,7 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp) struct rte_pci_device *pdev = bp->pdev; const struct rte_memzone *mz; char mz_name[RTE_MEMZONE_NAMESIZE]; - int entry_length = RTE_CACHE_LINE_ROUNDUP( + uint16_t entry_length = RTE_CACHE_LINE_ROUNDUP( HW_HASH_INDEX_SIZE * sizeof(*vnic->rss_table) + HW_HASH_KEY_SIZE); uint16_t max_vnics; -- 2.20.1