From e949eaa5b3c99b90aaa530cb9efb2af7aa69c654 Mon Sep 17 00:00:00 2001 From: Igor Russkikh Date: Mon, 29 Apr 2019 08:20:27 +0000 Subject: [PATCH] net/atlantic: fix arguments check Found by Coverity scan, two pointer args should be not zero checked Coverity issue: 337929 Fixes: 2f40244b39ba ("net/atlantic: implement MACsec firmware interface") Signed-off-by: Igor Russkikh --- drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c index 0d24aa99bd..5927d90f18 100644 --- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c +++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c @@ -671,7 +671,7 @@ static int aq_fw2x_send_macsec_request(struct aq_hw_s *self, int err = 0; u32 mpi_opts = 0; - if (!response || !response) + if (!req || !response) return 0; if ((self->caps_lo & BIT(CAPS_LO_MACSEC)) == 0) -- 2.20.1