From ef17b12e6a5a5e0a346cbaa4c7f2090dbb4b834e Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Mon, 31 Jul 2017 11:24:23 -0500 Subject: [PATCH] net/bnxt: fix arguments to callback process The callback arguments to _rte_eth_dev_callback_process() are swapped. Fix them. Fixes: d6af1a13d7a1 ("ethdev: add return values to callback process API") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/rte_pmd_bnxt.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c index dd7e5b85c6..c343d9033c 100644 --- a/drivers/net/bnxt/rte_pmd_bnxt.c +++ b/drivers/net/bnxt/rte_pmd_bnxt.c @@ -50,20 +50,21 @@ int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg) { - struct rte_pmd_bnxt_mb_event_param cb_param; + struct rte_pmd_bnxt_mb_event_param ret_param; - cb_param.retval = RTE_PMD_BNXT_MB_EVENT_PROCEED; - cb_param.vf_id = vf_id; - cb_param.msg = msg; + ret_param.retval = RTE_PMD_BNXT_MB_EVENT_PROCEED; + ret_param.vf_id = vf_id; + ret_param.msg = msg; _rte_eth_dev_callback_process(bp->eth_dev, RTE_ETH_EVENT_VF_MBOX, - &cb_param, NULL); + NULL, &ret_param); /* Default to approve */ - if (cb_param.retval == RTE_PMD_BNXT_MB_EVENT_PROCEED) - cb_param.retval = RTE_PMD_BNXT_MB_EVENT_NOOP_ACK; + if (ret_param.retval == RTE_PMD_BNXT_MB_EVENT_PROCEED) + ret_param.retval = RTE_PMD_BNXT_MB_EVENT_NOOP_ACK; - return cb_param.retval == RTE_PMD_BNXT_MB_EVENT_NOOP_ACK ? true : false; + return ret_param.retval == RTE_PMD_BNXT_MB_EVENT_NOOP_ACK ? + true : false; } int rte_pmd_bnxt_set_tx_loopback(uint8_t port, uint8_t on) -- 2.20.1