From f21c6e7f81f391318de2289916072cbb251d59b5 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Tue, 13 Oct 2020 14:45:44 +0100 Subject: [PATCH] common/sfc_efx/base: simplify requesting Rx prefix fields Introduce an extra variable with required Rx prefix fields mask to make it easier to request more fields. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/rhead_rx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/common/sfc_efx/base/rhead_rx.c b/drivers/common/sfc_efx/base/rhead_rx.c index d683f280ce..d3d7339b8c 100644 --- a/drivers/common/sfc_efx/base/rhead_rx.c +++ b/drivers/common/sfc_efx/base/rhead_rx.c @@ -594,6 +594,7 @@ rhead_rx_qcreate( const efx_nic_cfg_t *encp = efx_nic_cfg_get(enp); efx_mcdi_init_rxq_params_t params; efx_rx_prefix_layout_t erpl; + uint32_t fields_mask = 0; efx_rc_t rc; _NOTE(ARGUNUSED(id)) @@ -631,8 +632,8 @@ rhead_rx_qcreate( * which fields are required or may be allow to request so-called * default Rx prefix (which ID is equal to 0). */ - if ((rc = rhead_rx_choose_prefix_id(enp, - (1U << EFX_RX_PREFIX_FIELD_LENGTH), &erpl)) != 0) + fields_mask |= 1U << EFX_RX_PREFIX_FIELD_LENGTH; + if ((rc = rhead_rx_choose_prefix_id(enp, fields_mask, &erpl)) != 0) goto fail3; params.prefix_id = erpl.erpl_id; -- 2.20.1