From f264c7980ca5b5f574c5f4c93644daf702124e4d Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Wed, 27 Jun 2018 11:20:52 +0200 Subject: [PATCH] net/mlx5: fix invalid error check Since its return type is unsigned, if_nametoindex() returns 0 in case of error, never -1. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 90488af33b..ebe5cb6e32 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -192,13 +192,13 @@ int mlx5_ifindex(const struct rte_eth_dev *dev) { char ifname[IF_NAMESIZE]; - int ret; + unsigned int ret; ret = mlx5_get_ifname(dev, &ifname); if (ret) return ret; ret = if_nametoindex(ifname); - if (ret == -1) { + if (ret == 0) { rte_errno = errno; return -rte_errno; } -- 2.20.1