From f3cb39e882deea117249f2f92eb1b0f22578f0af Mon Sep 17 00:00:00 2001 From: Thomas Monjalon Date: Sat, 15 Jul 2017 12:00:33 +0200 Subject: [PATCH] devtools: add script to find duplicated includes Based on Stephen's idea (originally implemented in a Perl script), this is a shell script to find duplicated includes in a file. It looks for all the .c and .h files of the git repository. It is fast enough because automatically well parallelized. Suggested-by: Stephen Hemminger Signed-off-by: Thomas Monjalon Tested-by: Keith Wiles --- MAINTAINERS | 1 + devtools/check-dup-includes.sh | 37 ++++++++++++++++++++++++++++++++++ 2 files changed, 38 insertions(+) create mode 100755 devtools/check-dup-includes.sh diff --git a/MAINTAINERS b/MAINTAINERS index 05e5456b40..897277748d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -24,6 +24,7 @@ General Project Administration M: Thomas Monjalon T: git://dpdk.org/dpdk F: MAINTAINERS +F: devtools/check-dup-includes.sh F: devtools/check-maintainers.sh F: devtools/check-git-log.sh F: devtools/check-includes.sh diff --git a/devtools/check-dup-includes.sh b/devtools/check-dup-includes.sh new file mode 100755 index 0000000000..10365e4a12 --- /dev/null +++ b/devtools/check-dup-includes.sh @@ -0,0 +1,37 @@ +#! /bin/sh -e + +# Copyright 2017 Mellanox Technologies, Ltd. All rights reserved. +# +# Redistribution and use in source and binary forms, with or without +# modification, are permitted provided that the following conditions +# are met: +# +# * Redistributions of source code must retain the above copyright +# notice, this list of conditions and the following disclaimer. +# * Redistributions in binary form must reproduce the above copyright +# notice, this list of conditions and the following disclaimer in +# the documentation and/or other materials provided with the +# distribution. +# +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, +# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. +# IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY +# CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, +# TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE +# SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + +# Check C files in git repository for duplicated includes. +# Usage: devtools/check-dup-includes.sh [directory] + +dir=${1:-$(dirname $(readlink -m $0))/..} +cd $dir + +# speed up by ignoring Unicode details +export LC_ALL=C + +for file in $(git ls-files '*.[ch]') ; do + sed -rn 's,^[[:space:]]*#include[[:space:]]*[<"](.*)[>"].*,\1,p' $file | + sort | uniq -d | + sed "s,^,$file: duplicated include: ," +done -- 2.20.1