From f6da77d92ddc76bb5bd0ea9bf4ff044c9fde1a9b Mon Sep 17 00:00:00 2001 From: Fady Bader Date: Wed, 17 Jun 2020 11:24:31 +0300 Subject: [PATCH] meter: remove inline functions from export list The code didn't compile when using exported meter functions under Windows. error LNK2001: unresolved external symbol rte_meter_srtcm_color_aware_check error LNK2001: unresolved external symbol rte_meter_srtcm_color_blind_check error LNK2001: unresolved external symbol rte_meter_trtcm_color_aware_check error LNK2001: unresolved external symbol rte_meter_trtcm_color_blind_check error LNK2001: unresolved external symbol rte_meter_trtcm_rfc4115_color_aware_check error LNK2001: unresolved external symbol rte_meter_trtcm_rfc4115_color_blind_check The cause was that there were some inline functions that were included in the export list. To solve this the functions were removed from rte_meter_version.map export list which are implemented in the header and shouldn't be exported. Fixes: 655796d2b5fb ("meter: support RFC4115 trTCM") Fixes: 9d41beed24b0 ("lib: provide initial versioning") Cc: stable@dpdk.org Signed-off-by: Fady Bader --- lib/librte_meter/rte_meter_version.map | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/librte_meter/rte_meter_version.map b/lib/librte_meter/rte_meter_version.map index b493bcebe9..58859d4d76 100644 --- a/lib/librte_meter/rte_meter_version.map +++ b/lib/librte_meter/rte_meter_version.map @@ -1,12 +1,8 @@ DPDK_20.0 { global: - rte_meter_srtcm_color_aware_check; - rte_meter_srtcm_color_blind_check; rte_meter_srtcm_config; rte_meter_srtcm_profile_config; - rte_meter_trtcm_color_aware_check; - rte_meter_trtcm_color_blind_check; rte_meter_trtcm_config; rte_meter_trtcm_profile_config; @@ -16,8 +12,6 @@ DPDK_20.0 { DPDK_21 { global: - rte_meter_trtcm_rfc4115_color_aware_check; - rte_meter_trtcm_rfc4115_color_blind_check; rte_meter_trtcm_rfc4115_config; rte_meter_trtcm_rfc4115_profile_config; -- 2.20.1